-
Notifications
You must be signed in to change notification settings - Fork 0
+2,489
−1,518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
campb303
requested changes
Oct 19, 2020
There are several minor changes relating to code style that should be changed -- things like adjusting white space and changing the wording on documentation. There are some moderate issues that need to be addressed regarding styling and unintended displays in the sidebar. There is a significant issue now that the sidebar cannot be closed. This needs to be fixed. |
…removed debugging lines, updated matching function, and removed useHistory
campb303
requested changes
Oct 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very close to being mergeable. Look at the comments about deriving dark mode state from the theme and see if that can be done without passing a prop.
campb303
approved these changes
Oct 19, 2020
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug #61 as well