Skip to content

Feature item routing #66

Merged
merged 25 commits into from
Oct 19, 2020
Merged

Feature item routing #66

merged 25 commits into from
Oct 19, 2020

Conversation

celfreic
Copy link

Fixed bug #61 as well

@campb303 campb303 self-requested a review October 16, 2020 01:29
@campb303 campb303 added this to the v1 milestone Oct 16, 2020
@campb303 campb303 added feature-request Request for functionality that has not already been implemented frontend labels Oct 16, 2020
@campb303 campb303 self-assigned this Oct 19, 2020
src/App.js Outdated Show resolved Hide resolved
src/App.js Outdated Show resolved Hide resolved
src/App.js Outdated Show resolved Hide resolved
src/App.js Show resolved Hide resolved
src/App.js Show resolved Hide resolved
src/components/ItemView/ItemView.md Show resolved Hide resolved
src/components/ItemViewAppBar/ItemViewAppBar.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
@campb303
Copy link
Collaborator

There are several minor changes relating to code style that should be changed -- things like adjusting white space and changing the wording on documentation.

There are some moderate issues that need to be addressed regarding styling and unintended displays in the sidebar.

There is a significant issue now that the sidebar cannot be closed. This needs to be fixed.

@campb303 campb303 assigned celfreic and unassigned campb303 Oct 19, 2020
Christian Thomas Elfreich added 3 commits October 19, 2020 11:27
…removed debugging lines, updated matching function, and removed useHistory
Copy link
Collaborator

@campb303 campb303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very close to being mergeable. Look at the comments about deriving dark mode state from the theme and see if that can be done without passing a prop.

src/components/ItemTable/ItemTable.js Show resolved Hide resolved
src/components/ItemTableAppBar/ItemTableAppBar.js Outdated Show resolved Hide resolved
@campb303 campb303 merged commit c0c2f70 into master Oct 19, 2020
@campb303 campb303 deleted the feature-ItemRouting branch October 19, 2020 17:20
Sign in to join this conversation on GitHub.
Labels
feature-request Request for functionality that has not already been implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants